Question about MeasurementModel<MeasVar,StateVar>::Simulate

Submitted by jve on Mon, 2008-12-01 19:10

Hi,

I have a question about version: BFL 0.6.1

The class MeasurementModel the following template method:

template MeasVar
MeasurementModel::Simulate (const StateVar& x,
const StateVar& s,
int sampling_method,
void * sampling_args)
{
assert(_systemWithoutSensorParams == false);
_MeasurementPdf->ConditionalArgumentSet(0,x);
_MeasurementPdf->ConditionalArgumentSet(1,s);
Sample Simulated(MeasurementSizeGet());
_MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
MeasVar result = Simulated.ValueGet();
return result;
}

I am wondering if on the 4th line of the method Sample shouldn't
be replaced by Sample?

This because the grand-parent Pdf has the methode "bool SampleFrom
(Sample& one_sample, int method, void * args) const;"
Where T is MeasVar in the measurementmodel!

Same issue occur in the other Simulate method of the class MeasurementModel

Is it wrong, or did I missed something?

With best regards,

Jürge
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

‹ [Bug 577] Getting started guide typos and improvements Anohter question about MeasurementModel<MeasVar, StateVar>::Simulate: return type correct? ›
»

Question about MeasurementModel<MeasVar, StateVar>::Simulate

Submitted by Tinne De Laet on Tue, 2008-12-02 08:15.

On Monday 01 December 2008 20:05:30 Jurge van Eijck wrote:
> Hi,
>
> I have a question about version: BFL 0.6.1
>
> The class MeasurementModel the following template method:
>
> template MeasVar
> MeasurementModel::Simulate (const StateVar& x,
> const StateVar& s,
> int sampling_method,
> void * sampling_args)
> {
> assert(_systemWithoutSensorParams == false);
> _MeasurementPdf->ConditionalArgumentSet(0,x);
> _MeasurementPdf->ConditionalArgumentSet(1,s);
> Sample Simulated(MeasurementSizeGet());
> _MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
> MeasVar result = Simulated.ValueGet();
> return result;
> }
>
> I am wondering if on the 4th line of the method Sample shouldn't
> be replaced by Sample?
>
> This because the grand-parent Pdf has the methode "bool SampleFrom
> (Sample& one_sample, int method, void * args) const;"
> Where T is MeasVar in the measurementmodel!
>
I think you are right. What does the author (mister K) thinks of this remark?

Tinne
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

»

Question about MeasurementModel<MeasVar, StateVar>::Simulate

Submitted by Klaas Gadeyne on Tue, 2008-12-02 18:50.

On Tue, Dec 2, 2008 at 9:10 AM, Tinne De Laet
<tinne [dot] delaet [..] ...> wrote:
> On Monday 01 December 2008 20:05:30 Jurge van Eijck wrote:
>> Hi,
>>
>> I have a question about version: BFL 0.6.1
>>
>> The class MeasurementModel the following template method:
>>
>> template MeasVar
>> MeasurementModel::Simulate (const StateVar& x,
>> const StateVar& s,
>> int sampling_method,
>> void * sampling_args)
>> {
>> assert(_systemWithoutSensorParams == false);
>> _MeasurementPdf->ConditionalArgumentSet(0,x);
>> _MeasurementPdf->ConditionalArgumentSet(1,s);
>> Sample Simulated(MeasurementSizeGet());
>> _MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
>> MeasVar result = Simulated.ValueGet();
>> return result;
>> }
>>
>> I am wondering if on the 4th line of the method Sample shouldn't
>> be replaced by Sample?
>>
>> This because the grand-parent Pdf has the methode "bool SampleFrom
>> (Sample& one_sample, int method, void * args) const;"
>> Where T is MeasVar in the measurementmodel!
>>
> I think you are right. What does the author (mister K) thinks of this remark?

Seems like a copy paste error indeed. Can you change it, check if the
test suite still works, file a bug and attach a patch to the bug
report?

Thx,

Klaas
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

»

Question about MeasurementModel<MeasVar, StateVar>::Simulate

Submitted by Tinne De Laet on Wed, 2008-12-03 08:50.

....
> >> This because the grand-parent Pdf has the methode "bool SampleFrom
> >> (Sample& one_sample, int method, void * args) const;"
> >> Where T is MeasVar in the measurementmodel!
> >
> > I think you are right. What does the author (mister K) thinks of this
> > remark?
>
> Seems like a copy paste error indeed. Can you change it, check if the
> test suite still works, file a bug and attach a patch to the bug
> report?
I opened a bugreport (bug#599) for this error.

Tinne

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

»

Question about MeasurementModel<MeasVar, StateVar>::Simulate

Submitted by Klaas Gadeyne on Wed, 2008-12-03 08:20.

On Tue, Dec 2, 2008 at 7:48 PM, Klaas Gadeyne <klaas [dot] gadeyne [..] ...> wrote:
> On Tue, Dec 2, 2008 at 9:10 AM, Tinne De Laet
> <tinne [dot] delaet [..] ...> wrote:
>> On Monday 01 December 2008 20:05:30 Jurge van Eijck wrote:
>>> Hi,
>>>
>>> I have a question about version: BFL 0.6.1
>>>
>>> The class MeasurementModel the following template method:
>>>
>>> template MeasVar
>>> MeasurementModel::Simulate (const StateVar& x,
>>> const StateVar& s,
>>> int sampling_method,
>>> void * sampling_args)
>>> {
>>> assert(_systemWithoutSensorParams == false);
>>> _MeasurementPdf->ConditionalArgumentSet(0,x);
>>> _MeasurementPdf->ConditionalArgumentSet(1,s);
>>> Sample Simulated(MeasurementSizeGet());
>>> _MeasurementPdf->SampleFrom(Simulated, sampling_method,sampling_args);
>>> MeasVar result = Simulated.ValueGet();
>>> return result;
>>> }
>>>
>>> I am wondering if on the 4th line of the method Sample shouldn't
>>> be replaced by Sample?
>>>
>>> This because the grand-parent Pdf has the methode "bool SampleFrom
>>> (Sample& one_sample, int method, void * args) const;"
>>> Where T is MeasVar in the measurementmodel!
>>>
>> I think you are right. What does the author (mister K) thinks of this remark?
>
> Seems like a copy paste error indeed. Can you change it, check if the
> test suite still works, file a bug and attach a patch to the bug
> report?

BTW, with "you" above I meant Jurge :-)

Klaas
_______________________________________________
I hereby promise not to top-post on the
BFL mailing list
BFL [..] ...
http://lists.mech.kuleuven.be/mailman/listinfo/bfl

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

»